Display default action label in action selector #18398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bramkragten
approved these changes
Nov 2, 2023
bramkragten
reviewed
Nov 2, 2023
| ${this.defaultAction | ||
| ? ` (${this.hass!.localize( | ||
| `ui.panel.lovelace.editor.action-editor.actions.${this.defaultAction}` | ||
| ).toLowerCase()})` |
There was a problem hiding this comment.
Should we lowercase this? Shouldn't the translation handle that?
There was a problem hiding this comment.
We can lowercase the translation but we will have to capitalize the first letter when using as a select option 😅
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Different card can have different defaults for actions. This PR adds a label when the user select the "default" action.
This PR adds it for button card and tile card.
I didn't change the defaults in this PR but we should align the default between card in another PR (e.g. "togglable" domain should be the same across cards).
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: